Fix (test/actions): Excluded torch==1.9.1, platform=macos-latest tests
#960
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickfraser
changed the title
python=3.8, torch==1.9.1, platform=macos-latest teststorch==1.9.1, platform=macos-latest tests
|
Part of me still leans towards completely removing mac-os from the testing suite. We would need to go through the tests to remove any macos specific exception. We have already several tests disabled only for MacOS and we can't debug if anything goes wrong there. |
nickfraser
changed the title
torch==1.9.1, platform=macos-latest teststorch==1.9.1, platform=macos-latest tests
|
We'll merge this for now, and revisit if/when we want to disable all MacOSX test. |
Giuseppe5
pushed a commit
to Giuseppe5/brevitas
that referenced
this pull request
May 31, 2024
…tests (Xilinx#960) * Fix (test/actions): Excluded python=3.8, torch==1.9.1, platform=macos-latest tests. * Fix (tests/actions): Regenerated github actions YAML files. * Fix (tests/actions): Disabled all MaxOSX, `torch==1.9.1` tests * Fix (tests/actions): Regenerated github actions files.
nickfraser
added a commit
to nickfraser/brevitas
that referenced
this pull request
Jul 22, 2024
…tests (Xilinx#960) * Fix (test/actions): Excluded python=3.8, torch==1.9.1, platform=macos-latest tests. * Fix (tests/actions): Regenerated github actions YAML files. * Fix (tests/actions): Disabled all MaxOSX, `torch==1.9.1` tests * Fix (tests/actions): Regenerated github actions files.
nickfraser
added a commit
that referenced
this pull request
Jul 22, 2024
…tests (#960) * Fix (test/actions): Excluded python=3.8, torch==1.9.1, platform=macos-latest tests. * Fix (tests/actions): Regenerated github actions YAML files. * Fix (tests/actions): Disabled all MaxOSX, `torch==1.9.1` tests * Fix (tests/actions): Regenerated github actions files.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed failing MacOSX test. See #906, #958.