[AIE] Phi nodes need not be dominated #194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martien-de-jong
requested review from
abhinay-anubola,
abnikant,
andcarminati,
gbossu,
khallouh,
konstantinschwarz,
SagarMaheshwari99 and
stephenneuendorffer
as code owners
gbossu
reviewed
Sep 27, 2024
| (PtrAddUse.getParent() != AddrUse.getParent() || | ||
| Helper.dominates(MemI, PtrAddUse) || | ||
| Helper.dominates(PtrAddUse, AddrUse)); | ||
| }); |
There was a problem hiding this comment.
Discussed offline, ultimately, what we want to check is that there is no use of the address in between the two instructions, because those will get combined in a single one. Maybe define a IsBetweenOps lambda and simplify the long comment above?
martien-de-jong
force-pushed
the
martien.postinccombine
branch
from
8757993 to
8e7c17f
Compare
gbossu
approved these changes
Sep 27, 2024
Dominance checks don't apply to phi nodes. Ultimately we want to know whether we can move the two instructions together without breaking a dependence. Outline a complicated condition Also some clang-tidy issues.
martien-de-jong
force-pushed
the
martien.postinccombine
branch
from
8e7c17f to
cf1eed5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original safety test for a PTRADD LD/ST postinc combine was overly conservative.