[AIE2][AIE2P] Scalarize G_FABS #271
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
katerynamuts
requested review from
abhinay-anubola,
abnikant,
andcarminati,
gbossu,
khallouh,
konstantinschwarz,
martien-de-jong,
SagarMaheshwari99 and
stephenneuendorffer
as code owners
khallouh
reviewed
Jan 16, 2025
| @@ -73,3 +73,25 @@ body: | | |||
| $r1 = COPY %5(s32) | |||
| PseudoRET implicit $lr, implicit $r0, implicit $r1 | |||
| ... | |||
|
|
|||
| --- | |||
| name: test_fabs_v2s32 | |||
There was a problem hiding this comment.
Could you add a couple of more tests for a different supported element type and a larger vector?
katerynamuts
force-pushed
the
katemuts.fabs
branch
from
d244f2e to
7ae8ee1
Compare
katerynamuts
force-pushed
the
katemuts.fabs
branch
from
4448c69 to
500b1a4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.