[AIE2P] Support end to end bfp16 conversion C intrinsics #273
+645
−37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
khallouh
requested review from
abhinay-anubola,
abnikant,
andcarminati,
gbossu,
konstantinschwarz,
martien-de-jong,
SagarMaheshwari99 and
stephenneuendorffer
as code owners
khallouh
force-pushed
the
hamza.bfp16.conv
branch
from
f5734bb to
4a8a48a
Compare
khallouh
force-pushed
the
hamza.bfp16.conv
branch
2 times, most recently
from
e6b647e to
a50c1ba
Compare
khallouh
force-pushed
the
hamza.bfp16.conv
branch
from
a50c1ba to
be0030a
Compare
konstantinschwarz
approved these changes
Jan 18, 2025
| BuiltinID == AIE::BI__builtin_aie2p_v64accfloat_to_v64bfp16ebs16) | ||
| Ops.push_back(EmitScalarExpr(E->getArg(E->getNumArgs() - 1))); | ||
| if (BuiltinID == AIE::BI__builtin_aie2p_v64bfp16ebs8_to_v64bfp16ebs16) { | ||
| Ops.push_back(EmitScalarExpr(E->getArg(E->getNumArgs() - 2))); |
There was a problem hiding this comment.
Nit: I think we can just use E->getArg(2) and E->getArg(3) here, similar to below
|
|
||
| MachineInstrBuilder MI = MIB.buildInstr(OpCode, {DstReg}, {SrcReg}); | ||
|
|
||
| auto MantCopyMI = MIB.buildInstr(TargetOpcode::COPY, {DstReg1}, {}) |
There was a problem hiding this comment.
nit: next time we write this COPY code, maybe introduce a helper function?
|
|
||
| MachineInstrBuilder MI = MIB.buildInstr(OpCode, {DstReg}, {SrcReg}); | ||
|
|
||
| auto MantCopyMI = MIB.buildInstr(TargetOpcode::COPY, {DstReg1}, {}) |
There was a problem hiding this comment.
same here, we could have a helper that creates the COPYs for mantissa and exponent
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.