Skip to content

[AIE] Enable floatdidf builtin used by G_SITOFP #436

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: aie-public
Choose a base branch
from
Open

[AIE] Enable floatdidf builtin used by G_SITOFP #436

wants to merge 1 commit into from

Conversation

jseaton
Copy link
Contributor

@jseaton jseaton commented Apr 14, 2025

Hi, for G_SITOFP instructions you seem to now emit calls to __floatdidf for int64_t -> double, however this builtin is disabled.
This causes a linker error when compiling some code that contains an int64_t -> double cast. I stumbled across this while trying to reuse Arm's cosf implementation.
Checked vs floatdidf_test.c values on AIE2 hardware.

@andcarminati
Copy link
Collaborator

I think we could also reabase the commit on top of an aie-public-derived branch (without the second merge commit). It will help to merge this change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martien-de-jong martien-de-jong martien-de-jong approved these changes

@abhinay-anubola abhinay-anubola Awaiting requested review from abhinay-anubola abhinay-anubola is a code owner

@abnikant abnikant Awaiting requested review from abnikant abnikant is a code owner

@andcarminati andcarminati Awaiting requested review from andcarminati andcarminati is a code owner

@F-Stuckmann F-Stuckmann Awaiting requested review from F-Stuckmann F-Stuckmann is a code owner

@gbossu gbossu Awaiting requested review from gbossu gbossu is a code owner

@katerynamuts katerynamuts Awaiting requested review from katerynamuts katerynamuts is a code owner

@khallouh khallouh Awaiting requested review from khallouh khallouh is a code owner

@konstantinschwarz konstantinschwarz Awaiting requested review from konstantinschwarz konstantinschwarz is a code owner

@niwinanto niwinanto Awaiting requested review from niwinanto niwinanto is a code owner

@SagarMaheshwari99 SagarMaheshwari99 Awaiting requested review from SagarMaheshwari99 SagarMaheshwari99 is a code owner

@stephenneuendorffer stephenneuendorffer Awaiting requested review from stephenneuendorffer stephenneuendorffer is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jseaton @andcarminati @martien-de-jong