Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fully unroll for-loops with tripCount < unrollFactor #1568

Merged
merged 15 commits into from
Aug 7, 2024
Merged

Fully unroll for-loops with tripCount < unrollFactor #1568

merged 15 commits into from
Aug 7, 2024

Conversation

AndraBisca
Copy link
Collaborator

Fixes #1556

AndraBisca and others added 4 commits June 17, 2024 20:24
@AndraBisca @github-actions
Update lib/Dialect/AIE/Transforms/AIEObjectFifoStatefulTransform.cpp
38f847b 
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@AndraBisca @github-actions
Update lib/Dialect/AIE/Transforms/AIEObjectFifoStatefulTransform.cpp
7c9c5d4 
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@AndraBisca @github-actions
Update lib/Dialect/AIE/Transforms/AIEObjectFifoStatefulTransform.cpp
27f4083 
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@AndraBisca @github-actions
Update lib/Dialect/AIE/Transforms/AIEObjectFifoStatefulTransform.cpp
c01562d 
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@AndraBisca AndraBisca marked this pull request as draft June 17, 2024 18:30
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 6, 2024 •
edited
Loading

Coverage Report

Created: 2024-08-06 19:31

Click here for information about interpreting this report.

FilenameFunction CoverageLine CoverageRegion CoverageBranch Coverage
home/runner/work/mlir-aie/mlir-aie/lib/Dialect/AIE/Transforms/AIEObjectFifoStatefulTransform.cpp 100.00% 94.13% 92.61% 87.27%
Totals 100.00% 94.13% 92.61% 87.27%
Generated by llvm-cov -- llvm version 14.0.0

@AndraBisca AndraBisca marked this pull request as ready for review August 6, 2024 13:35
@AndraBisca AndraBisca changed the title Fully unroll for-loops with less iterations than unrollFactor Fully unroll for-loops with tripCount < unrollFactor Aug 6, 2024
@AndraBisca AndraBisca mentioned this pull request Aug 6, 2024
Open
@AndraBisca AndraBisca requested a review from fifield August 6, 2024 19:28
@AndraBisca AndraBisca added this pull request to the merge queue Aug 7, 2024
Merged via the queue into main with commit 80fb5c0 Aug 7, 2024
51 checks passed
@AndraBisca AndraBisca deleted the unroll-bug branch August 7, 2024 14:22
@AndraBisca AndraBisca mentioned this pull request Aug 7, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@stephenneuendorffer stephenneuendorffer Awaiting requested review from stephenneuendorffer stephenneuendorffer is a code owner

@makslevental makslevental Awaiting requested review from makslevental

@fifield fifield Awaiting requested review from fifield fifield is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

MLIR::loopUnrollByFactor fails for small loops
3 participants
@AndraBisca @fifield @abisca