Change Default Matrix Multiplication Data Type to Integer; Add Documentation on Numerical Tolerances #1615
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrej
requested review from
makslevental,
AndraBisca,
denolf,
jgmelber,
fifield and
stephenneuendorffer
as code owners
…M, fix offsets for reused BDs into C
…nce with integer outputs; add i32 output type support
jgmelber
approved these changes
Jul 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed with @jamesroxbypb and @jgmelber. Switches default data type to integer and checks for strict equivalence if outputs are integer. This should give us more robustness in the matrix multiplication verification.
Please have a look at the section added to the
README.md.