-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fall back routine when bank-aware allocation fails #1625
Open
pvasireddy-amd
wants to merge
73
commits into
main
Choose a base branch
from
alloc-flags
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pvasireddy-amd
changed the title
Fall back routine for bank-aware allocation scheme
Fall back routine for bank-aware allocation failure
Jul 17, 2024
pvasireddy-amd
changed the title
Fall back routine for bank-aware allocation failure
Fall back routine when bank-aware allocation fails
Jul 17, 2024
pvasireddy-amd
requested review from
stephenneuendorffer,
jgmelber,
fifield,
jackl-xilinx and
denolf
as code owners
September 19, 2024 19:59
…or failure of tests
fifield
approved these changes
Sep 19, 2024
for (auto tile : device.getOps<TileOp>()) { | ||
if (auto res = simpleBankAwareAllocation(tile); res.failed()) | ||
return signalPassFailure(); | ||
} | ||
} else { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
might want to warn or error here if clAllocScheme was given by user but unrecognized
Option<"clBasicAlloc", "basic-alloc", "bool", /*default=*/"false", | ||
"Flag to enable the basic sequential allocation scheme (not bank-aware)."> | ||
Option<"clAllocScheme", "alloc-scheme", "std::string", /*default=*/"", | ||
"Choose allocation scheme; possibilities: basic-sequential, bank-aware. By default, bank-aware is selected and if it fails, will fall back to basic-sequential scheme.">, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could this be made to fit into ~80-100 columns?
This reverts commit 04dcd7f.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds flags for the user to select the allocation scheme. When no allocation scheme is given, bank-aware allocation is selected as default and when it fails, sequential allocation is performed.