[aievec] MLIR->LLVM flow for float inverse #1697
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
August 15, 2024 12:12
Still need to add conversion test
aidansander
requested review from
stephenneuendorffer,
jgmelber,
fifield,
jackl-xilinx and
jsetoain
as code owners
|
|
||
| auto constOp = divOp.getLhs().getDefiningOp<arith::ConstantOp>(); | ||
| if (!constOp || | ||
| cast<FloatAttr>(constOp.getValue()).getValue().convertToDouble() != |
There was a problem hiding this comment.
just curious, does this FloatAttr floating point comparison include a built-in epsilon for err?
There was a problem hiding this comment.
It is a comparison is between double values, not FloatAttr objects. FloatAttr::getValue() returns an APFloat, and APFloat::convertToDouble() returns a double. So, no epsilon.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a conversion pattern similar to
ComputeInvOpByLUTPattern, but targeting the LLVMIR backend.