Configure AIE using control packets #1728
Conversation
erwei-xilinx
requested review from
stephenneuendorffer,
jgmelber,
fifield,
jackl-xilinx and
AndraBisca
as code owners
| npu_maskwrite32(addr, value, mask) | ||
| else: | ||
| raise Exception(f"Unhandled op: {op:#x}") | ||
| if mlir_ctrl_pkt: |
There was a problem hiding this comment.
This is a nice quick way to get a proof of concept but I think npu op to control packet conversion should be an mlir pass in C++ if it is going to be supported in mlir-aie. Converting runtime sequence mlir to a binary blob then to control packet mlir is a bit hacky.
There was a problem hiding this comment.
Totally agreed. I'm thinking that perhaps ideally there should be an mlir pass that converts write32/blockwrite/maskedwrite32 ops into control packet ops, and another pass that converts control packet ops to dma_memcpy_nd ops represeting shim dma issuing control packet writes to tiles. Let me create an issue to extend this discussion.
There was a problem hiding this comment.
Sounds good. This txn2mlir.py script is mostly intended to be a disassembler and debugging aid. It is not intended to be load bearing.
There was a problem hiding this comment.
Issue created: #1729
There was a problem hiding this comment.
Ideally this file should be generated as part of the test
There was a problem hiding this comment.
Agreed. Locally this file is generated by mlir passes. Let me create a separate PR for those passes that I'm working on locally.
Agreed. Will rebase after that one lands on main with more tests. |
txn2mlir.pycan now generate control packet ops that work.