[WIP] IRON API and Dev Tools #1732
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hunhoffe
force-pushed
the
erika-iron-brainstorming
branch
from
2e19d04
to
ea55152
Compare
Coverage ReportCreated: 2024-10-14 18:21Click here for information about interpreting this report.
Generated by llvm-cov -- llvm version 14.0.0 |
hunhoffe
force-pushed
the
erika-iron-brainstorming
branch
2 times, most recently
from
229acf4
to
e103e35
Compare
hunhoffe
changed the title
hunhoffe
force-pushed
the
erika-iron-brainstorming
branch
from
4251bea
to
1c22e32
Compare
hunhoffe
commented
Sep 25, 2024
hunhoffe
commented
Sep 25, 2024
hunhoffe
changed the title
hunhoffe
force-pushed
the
erika-iron-brainstorming
branch
from
f83c852
to
649065c
Compare
hunhoffe
force-pushed
the
erika-iron-brainstorming
branch
from
7fda896
to
181368a
Compare
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
hunhoffe
changed the title
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| TILE_SIZE = TILE_WIDTH * TILE_HEIGHT | ||
|
|
||
| with mlir_mod_ctx() as ctx: | ||
| def my_matrix_add_one(): |
There was a problem hiding this comment.
[black] reported by reviewdog 🐶
Suggested change
| def my_matrix_add_one(): | |
| def my_matrix_add_one(): |
|
|
||
| @runtime_sequence(tile_ty, tile_ty, tile_ty) | ||
| def sequence(inTensor, _, outTensor): | ||
| npu_dma_memcpy_nd(metadata=of_in1, bd_id=1, |
There was a problem hiding this comment.
[black] reported by reviewdog 🐶
Suggested change
| npu_dma_memcpy_nd(metadata=of_in1, bd_id=1, | |
| npu_dma_memcpy_nd( | |
| metadata=of_in1, | |
| bd_id=1, |
| issue_token=True, | ||
| ) | ||
|
|
||
| npu_dma_memcpy_nd(metadata=of_out1, bd_id=0, |
There was a problem hiding this comment.
[black] reported by reviewdog 🐶
Suggested change
| npu_dma_memcpy_nd(metadata=of_out1, bd_id=0, | |
| npu_dma_memcpy_nd( | |
| metadata=of_out1, | |
| bd_id=0, |
| TILE_HEIGHT, TILE_WIDTH = 8, 16 | ||
| TILE_SIZE = TILE_WIDTH * TILE_HEIGHT | ||
|
|
||
| def my_matrix_add_one(): |
There was a problem hiding this comment.
[black] reported by reviewdog 🐶
Suggested change
| def my_matrix_add_one(): | |
| def my_matrix_add_one(): |
Comment on lines
+39
to
+41
| my_worker = Worker(core_fn, | ||
| fn_args=[of_in.second, of_out.first], | ||
| while_true=True) |
There was a problem hiding this comment.
[black] reported by reviewdog 🐶
Suggested change
| my_worker = Worker(core_fn, | |
| fn_args=[of_in.second, of_out.first], | |
| while_true=True) | |
| my_worker = Worker(core_fn, fn_args=[of_in.second, of_out.first], while_true=True) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please ignore, not nearly ready for consideration.