Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable region simplification in --aie-substitute-shim-dma-allocations pass #1755

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

andrej
Copy link
Collaborator

@andrej andrej commented Sep 6, 2024

The pattern rewriter in this pass previously also performed region simplification, which caused an assertion error if the MLIR contained blocks with input arguments, such as generated by:

          %7 = scf.if %6 -> (memref<64x32xf32>) {
            scf.yield %C_L1L2_0_0_buff_0 : memref<64x32xf32>
          } else {
            scf.yield %C_L1L2_0_0_buff_1 : memref<64x32xf32>
          }

This fixes that issue. I don't fully understand why the issue exists with region simplification, but the point of this pass is not to simplify regions anyways, so it is fine to disable.

@fifield
Copy link
Collaborator

fifield commented Sep 6, 2024

Seems like red-flag that the IR is left in a bad state somewhere. Do you have a failing (fixed) test you can add to the PR?

@jgmelber
Copy link
Collaborator

@andrej is this still needed after the dynamic object FIFO implementation landed? @AndraBisca

@andrej
Copy link
Collaborator Author

andrej commented Oct 23, 2024

Oops, forgot about this one. Yes I believe this is still needed. I can work on a test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants