Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add repeat support for compute tiles #1842

Draft
wants to merge 21 commits into
base: main
Choose a base branch
from
Draft

Conversation

AndraBisca
Copy link
Collaborator

@AndraBisca AndraBisca commented Oct 16, 2024

Currently, a repeat value can be specified for Mem tiles via the objectfifo's memtile_repeat attribute. This PR extends it to compute tiles as well.

Specifically:

  • the objectfifo attribute name is changed from memtile_repeat to repeat_count,
  • this PR also changes the value that repeat_count represents for objectfifos: a repeat of 'n' means 'n' total copies of that data will be transferred including the first one,
  • this PR ensures that if the repeat_count attribute of the objectfifo is set, the objectfifo lowering will always use DMAs,
  • currently the objectfifo attribute is lowered to the repeat_count attribute of DMAStartOps for Mem tiles: this is added for compute tiles,
  • currently a repeat value can also be specified using data layout transformation dimensions in the objectfifo for Mem tiles: this is removed as the repeat dimension is not actually exposed in mlir-aie and this features (wrongly) assumed the highest dimension was the repeat dimension.

TODO: add documentation to programming guide

Copy link
Contributor

github-actions bot commented Oct 18, 2024

Coverage Report

Created: 2024-10-21 18:37

Click here for information about interpreting this report.

FilenameFunction CoverageLine CoverageRegion CoverageBranch Coverage
IR/AIEDialect.cpp 89.63% 82.21% 84.72% 74.71%
Transforms/AIEObjectFifoStatefulTransform.cpp 100.00% 93.92% 91.76% 85.66%
Totals 92.05% 87.78% 87.24% 79.01%
Generated by llvm-cov -- llvm version 14.0.0

@hunhoffe hunhoffe self-requested a review October 21, 2024 18:07
@AndraBisca AndraBisca marked this pull request as ready for review October 21, 2024 18:31
@AndraBisca AndraBisca marked this pull request as draft October 22, 2024 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants