Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Monthly Merge Dev-Upgrade to Master Branch #499

Merged
merged 23 commits into from
Mar 24, 2024
Merged

Monthly Merge Dev-Upgrade to Master Branch #499

merged 23 commits into from
Mar 24, 2024

Conversation

liam-lai
Copy link
Collaborator

@liam-lai liam-lai commented Mar 20, 2024 •
edited
Loading

Proposed changes

Monthly Merge Dev-Upgrade to Master Branch

#486
#490
#491
#492
#496
#493
#488
#484
#489

revert pr: #484

Types of changes

What types of changes does your code introduce to XDC network?
Put an ✅ in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)
  • Regular KTLO or any of the maintaince work. e.g code style
  • CICD Improvement

Impacted Components

Which part of the codebase this PR will touch base on,

Put an ✅ in the boxes that apply

  • Consensus
  • Account
  • Network
  • Geth
  • Smart Contract
  • External components
  • Not sure (Please specify below)

Checklist

Put an ✅ in the boxes once you have confirmed below actions (or provide reasons on not doing so) that

  • This PR has sufficient test coverage (unit/integration test) OR I have provided reason in the PR description for not having test coverage
  • Provide an end-to-end test plan in the PR description on how to manually test it on the devnet/testnet.
  • Tested the backwards compatibility.
  • Tested with XDC nodes running this version co-exist with those running the previous version.
  • Relevant documentation has been updated as part of this PR
  • N/A

wanwiset25 and others added 21 commits March 11, 2024 13:19
@wanwiset25
core/state: abort commit if errors have occurred (#484)
0114eca
@liam-lai
add pull request trigger test (#488)
2fcd6f4 
Co-authored-by: Liam Lai <liam.lai@datameshgroup.com>
@gzliudan
internal/ethapi: support block number or hash on state-related methods (
4616d59 
ethereum#19491)

* Support for EIP-1898.
@gzliudan
eth: check err before return in function StateAndHeaderByNumber
f340875
@gzliudan
eth: let function HeaderByNumber return error when header is nil
b2a767e
@gzliudan
Merge pull request #486 from gzliudan/EIP-1898
106af4d 
implement EIP-1898
@wanwiset25
Revert "core/state: abort commit if errors have occurred (#484)" (#489)
8edb76f 
This reverts commit 0114eca.
@reductionista @gzliudan
eth/filters, ethereum: EIP-234 add blockHash param for eth_getLogs
69b4383
@gzliudan
Merge pull request #490 from gzliudan/eip234
4938ba7 
implement EIP-234: add blockHash param for eth_getLogs
@wang-gerui
remove 1s waiting time in miner
28480b1
@liam-lai
after we use time.Ticker it didn't allow to have 0 time duration (#493)
bbab326 
* after we use time.Ticker it didn't allow to have 0 time duration
@wgr523
Merge pull request #492 from XinFinOrg/xdc-05
04cf52b 
XDC-05 remove 1s waiting time in miner
@gzliudan
eth/filter: check nil pointer when unsubscribe (ethereum#16682)
7197172 
* eth/filter: check nil pointer when unsubscribe

* eth/filters, accounts, rpc: abort system if subscribe failed

* eth/filter: add crit log before exit

* eth/filter, event: minor fixes
@knarfeh @gzliudan
eth/filters: make filterLogs func more readable (ethereum#16920)
19b84ff
@gzliudan
accounts, eth, les: blockhash based filtering on all code paths (ethe…
a4b557b 
…reum#16734)
@macalinao @gzliudan
eth/filters: improve error message for invalid filter topics (ethereu…
40ee6f8 
…m#17234)
@gzliudan
eth/filters: simplify switches (ethereum#17267)
43f038d
@rjl493456442 @gzliudan
eth/filters: fix the block range assignment for log filter (ethereum#…
65b4815 
…17284)
@gzliudan
eth/filters: replace fmt.Println with b.Log in tests (ethereum#19670)
7cffa1d
@gzliudan
Merge pull request #491 from gzliudan/filter
4d8effe 
improve package eth/filter
@liam-lai
Ci improvement (#496)
42c57c6 
* move devnet rpc node to rpc terraform and start to tag by sha
@wjrjerome @jrwbabylonlab
drop peer if received bad block data which does not include the valid…
816dce9 
…ator field (#494)

Co-authored-by: wjrjerome <wjrjerome@babylonchain.io>
@liam-lai liam-lai merged commit fd8e7c9 into master Mar 24, 2024
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wanwiset25 wanwiset25 wanwiset25 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@liam-lai @wanwiset25 @wjrjerome @gzliudan @reductionista @wang-gerui @wgr523 @knarfeh @macalinao @rjl493456442