Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

all: migrate go-bindata to embed #806

Merged
merged 1 commit into from
Jan 22, 2025

Conversation

gzliudan
Copy link
Collaborator

@gzliudan gzliudan commented Jan 20, 2025

Proposed changes

This PR migrates go-bindata to embed.

Ref: ethereum#24744

TODO: remove the file eth/tracers/js/internal/tracers/assets.go and solve the following test failure:

--- FAIL: TestZeroValueToNotExitCall (0.00s)
    tracers_test.go:153: failed to create call tracer: ReferenceError: identifier 'callTracer' undefined
FAIL
FAIL    github.com/XinFinOrg/XDPoSChain/eth/tracers     0.147s

Types of changes

What types of changes does your code introduce to XDC network?
Put an in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)
  • Regular KTLO or any of the maintaince work. e.g code style
  • CICD Improvement

Impacted Components

Which part of the codebase this PR will touch base on,

Put an in the boxes that apply

  • Consensus
  • Account
  • Network
  • Geth
  • Smart Contract
  • External components
  • Not sure (Please specify below)

Checklist

Put an in the boxes once you have confirmed below actions (or provide reasons on not doing so) that

  • This PR has sufficient test coverage (unit/integration test) OR I have provided reason in the PR description for not having test coverage
  • Provide an end-to-end test plan in the PR description on how to manually test it on the devnet/testnet.
  • Tested the backwards compatibility.
  • Tested with XDC nodes running this version co-exist with those running the previous version.
  • Relevant documentation has been updated as part of this PR
  • N/A

@gzliudan gzliudan changed the title all: migrate go-bindata to embed [WIP] all: migrate go-bindata to embed Jan 20, 2025
@gzliudan gzliudan changed the title [WIP] all: migrate go-bindata to embed all: migrate go-bindata to embed Jan 22, 2025
@gzliudan gzliudan merged commit bc2f68d into XinFinOrg:dev-upgrade Jan 22, 2025
13 checks passed
@gzliudan gzliudan deleted the migrate_to_embed branch January 22, 2025 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants