Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Camera parameters should be float instead of int (return of pyflex.get_camera_params) #34

Open
TMats opened this issue Apr 25, 2022 · 0 comments

Comments

@TMats
Copy link

TMats commented Apr 25, 2022

Hello developers!
Thank you very much for the active developments!

Since the camera parameters (position & rotation) are float, I think these lines are buggy,

py::array_t<int> pyflex_get_camera_params() {
// Right now only returns width and height for the default screen camera
// yf: add the camera position and camera angle
auto default_camera_param = py::array_t<float>(8);
auto default_camera_param_ptr = (float *) default_camera_param.request().ptr;
default_camera_param_ptr[0] = g_screenWidth;
default_camera_param_ptr[1] = g_screenHeight;
default_camera_param_ptr[2] = g_camPos.x;
default_camera_param_ptr[3] = g_camPos.y;
default_camera_param_ptr[4] = g_camPos.z;
default_camera_param_ptr[5] = g_camAngle.x;
default_camera_param_ptr[6] = g_camAngle.y;
default_camera_param_ptr[7] = g_camAngle.z;
return default_camera_param;
}

So, the return should be py::array_t<float> instead of py::array_t<int>?

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant