Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[80_4] Improving the Typesetting of Limit Boxes #2114

Merged
merged 2 commits into from
Oct 3, 2024

Conversation

KeShih
Copy link
Contributor

@KeShih KeShih commented Sep 29, 2024

What

Improving the Typesetting of Limit Boxes.

Why

For some OpenType fonts, the heights of the upper and lower limits in the limit box environment are not suitable.

How to test your changes?

Open devel/80_4.tmu.

Before (Anasa Math font), the upper limit is too high:
image

After:
image

Copy link
Contributor

@da-liii da-liii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, and please resolve the two crucial review comments and then I will merge it

@da-liii
Copy link
Contributor

da-liii commented Oct 1, 2024

And I tested it in your branch:
image

@da-liii da-liii merged commit 06912c2 into XmacsLabs:branch-1.2 Oct 3, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants