Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code Fefactor on PSD2 Issue #1

Merged
merged 2 commits into from
Sep 17, 2024

Conversation

christopher-henderson
Copy link

@christopher-henderson christopher-henderson commented Sep 15, 2024

  • Moved parsing logic into a so called "parse constructor"
    • Users construct either a OrganizationIdentifier{ParseAsPSD: false} or OrganizationIdentifier{ParseAsPSD: true} and then calls Parse on that variant to populate the struct from the given string.

@christopher-henderson christopher-henderson changed the title code refactor Code Fefactor on PSD2 Issue Sep 15, 2024
@XolphinMartijn XolphinMartijn merged commit a8bfb10 into XolphinMartijn:master Sep 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants