Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

please support webtoon bestChallenge and challenge #236

Closed
gfhghfghfh opened this issue Jun 23, 2019 · 6 comments · Fixed by #309
Closed

please support webtoon bestChallenge and challenge #236

gfhghfghfh opened this issue Jun 23, 2019 · 6 comments · Fixed by #309

Comments

@gfhghfghfh
Copy link

gfhghfghfh commented Jun 23, 2019

https://comic.naver.com/genre/bestChallenge.nhn
https://comic.naver.com/genre/challenge.nhn

@gfhghfghfh gfhghfghfh changed the title please support webtoon bestChallenge please support webtoon bestChallenge and challenge Jun 23, 2019
@Xonshiz
Copy link
Owner

Xonshiz commented Apr 16, 2022

Naver is already supported. You should be able to pass the link of the comic to the tool and it'll download all the images in it.

@gfhghfghfh
Copy link
Author

gfhghfghfh commented Apr 16, 2022

@Xonshiz
Copy link
Owner

Xonshiz commented Apr 16, 2022

Just looked at the code. Well, this should've worked. But, looks like Naver has changed their URL scheme, that's the reason this isn't going through. Either they changed their URL scheme and the whole Naver download is broken or they introduced a new scheme as well.

Anyways, thanks for bringing this to notice. I'm re-opening this issue and will push a fix for this by tomorrow probably. Thanks for waiting such a long time and apologies :)

@Xonshiz Xonshiz reopened this Apr 16, 2022
@Xonshiz Xonshiz self-assigned this Apr 16, 2022
@Xonshiz Xonshiz added the bug label Apr 16, 2022
@gfhghfghfh
Copy link
Author

gfhghfghfh commented Apr 16, 2022

thanks

"But, looks like Naver has changed their URL scheme"
Regarding the issues mentioned above

I list some examples

not working
comic_dl.exe -i https://comic.naver.com/bestChallenge/list.nhn?titleId=789786
comic_dl.exe -i https://comic.naver.com/bestChallenge/list?titleId=789786
comic_dl.exe -i https://comic.naver.com/webtoon/list?titleId=670152

working
comic_dl.exe -i https://comic.naver.com/webtoon/list.nhn?titleId=670152

@Xonshiz
Copy link
Owner

Xonshiz commented Apr 16, 2022

Looks like new scheme got added as well.
I picked these from comic.naver.com Homepage itself:
https://comic.naver.com/webtoon/list?titleId=775318
https://comic.naver.com/webtoon/list?titleId=774044

These are the newly added URL schemes.

Anything with list.nhn or details.nhn will work.
I'll add support for these new ones too. Then your challenge and bestChallenge ones should work too :)

Cool, I'll try to push the new changes by tomorrow (or in next few hours).

Xonshiz added a commit that referenced this issue Apr 16, 2022
- Closes #236
- Added support for TMOFans/lectortmo.com [Fix for #231 ]
- Removed some unnecessary comments.
- Fixed an extra method parameter in `japscan`.
Xonshiz added a commit that referenced this issue Apr 16, 2022
- Closes #236
- Added support for TMOFans/lectortmo.com [Fix for #231 ]
- Removed some unnecessary comments.
- Fixed an extra method parameter in `japscan`.

Guess who wasn't lazy this weekend ;)
@Xonshiz
Copy link
Owner

Xonshiz commented Apr 16, 2022

I've added a fix for this issue. The latest binaries should be available as soon as GitHub Action completes and creates a new release. Please feel free to re-open if something doesn't work as expected.

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants