Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Config Generator not adding cookie option to config.json #335

Closed
cstegmann opened this issue Mar 1, 2023 · 0 comments · Fixed by #338
Closed

Config Generator not adding cookie option to config.json #335

cstegmann opened this issue Mar 1, 2023 · 0 comments · Fixed by #338

Comments

@cstegmann
Copy link

When using the the config generator to create a config.json there is no entry regarding the cookie. Running the script / docker container will result in an error:

2023-03-01 15:06:03 Traceback (most recent call last):
2023-03-01 15:06:03   File "/opt/comic-dl/cli.py", line 5, in <module>
2023-03-01 15:06:03     main()
2023-03-01 15:06:03   File "/opt/comic-dl/comic_dl/__main__.py", line 20, in main
2023-03-01 15:06:03     ComicDL(sys.argv[1:])
2023-03-01 15:06:03   File "/opt/comic-dl/comic_dl/comic_dl.py", line 135, in __init__
2023-03-01 15:06:03     manual_cookie = data["cookie"]
2023-03-01 15:06:03 KeyError: 'cookie'

Example output from docker run -it --name comic-dl-config --rm -v /c/Users/Username/ComicDL:/directory:rw -w /directory ghcr.io/xonshiz/comic-dl:latest_linux_amd64 comic_dl -dd /directory --config
:

{
    "download_directory": "comics",
    "sorting_order": "ascending",
    "Configconversion": "cbz",
    "keep": "False",
    "image_quality": "Best",
    "comics": {
        "https://fanfox.net/manga/the_youngest_son_of_a_master_swordsman/": {
            "url": "https://fanfox.net/manga/the_youngest_son_of_a_master_swordsman/",
            "next": 1,
            "last": "None",
            "username": "None",
            "password": "None",
            "comic_language": "0"
        }
    }
}

Adding a "cookie": "None", data entry to the config.json file lets the script run as normal when using the --auto flag.

darodi added a commit to darodi/comic-dl that referenced this issue Mar 13, 2023
Xonshiz pushed a commit that referenced this issue Mar 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant