Number friendness for next chapter #135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you @dsanchezseco as usual for the amazing work. I had to reinstall my OS, so it'll take me a few days to set up my python env. As soon as I'm done, I'll release the updated windows binary as well :D |
Xonshiz
reviewed
May 20, 2018
darodi
added a commit
to darodi/comic-dl
that referenced
this pull request
Jul 11, 2018
…apter : error in commit b67e058
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #133 actually nothing was needed to be done to use the next in the correct way. Just change the initial 0 with a 1. The rest was OK as next chapter is equal array length.
Also done the use of the config directly instead of in a tmp