proxy: proxy is default code generation mode #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Proxy mode is the recommended mode of operation for grpc-jersey, so it should also be the default code generation mode. Users of the direct mode often ask how to use their existing gRPC interceptors for auth, so this should just be provided behavior. Existing users of the `proxy` option will not need to change their projects, `proxy` is now a no-op. Instead, users who wish to use the server stub mode should add `direct` to their jersey plugin options (see README).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proxy mode is the recommended mode of operation for grpc-jersey, so it
should also be the default code generation mode. Users of the direct
mode often ask how to use their existing gRPC interceptors for auth, so
this should just be provided behavior.
Existing users of the
proxyoption will not need to change theirprojects,
proxyis now a no-op.Instead, users who wish to use the server stub mode should add
directto their jersey plugin options (see README).