Skip to content

Commit

Permalink
#1161 outdated versions of gstreamer cause problems with the gdp and …
Browse files Browse the repository at this point in the history
…matroskademux muxers, the receiver may not be able to process the data and we have no way of knowing what version they have at this point, so just disable those

git-svn-id: https://xpra.org/svn/Xpra/trunk@12356 3bb7dfac-3a0b-4e04-842a-767bc560f471
  • Loading branch information
totaam committed Apr 8, 2016
1 parent 883d8e6 commit 6affc31
Showing 1 changed file with 6 additions and 0 deletions.
6 changes: 6 additions & 0 deletions src/xpra/sound/gstreamer_util.py
Original file line number Diff line number Diff line change
Expand Up @@ -430,6 +430,12 @@ def get_codecs():
continue
if force_enabled(encoding):
log.info("sound codec %s force enabled", encoding)
elif len([x for x in elements if (x and (x.find("matroska")>=0 or x.find("gdp")>=0))])>0 and get_gst_version()<(0, 10, 36):
#outdated versions of gstreamer cause problems with the gdp and matroskademux muxers,
#the receiver may not be able to process the data
#and we have no way of knowing what version they have at this point, so just disable those:
log("avoiding %s with gdp muxer - gstreamer version %s is too old", encoding, get_gst_version())
continue
elif encoding==FLAC:
#flac problems:
if WIN32 and gst_major_version==0:
Expand Down

0 comments on commit 6affc31

Please sign in to comment.