Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xpra 5.0-r32148-1 cannot connect via ssh #3662

Closed
allo- opened this issue Oct 21, 2022 · 3 comments
Closed

xpra 5.0-r32148-1 cannot connect via ssh #3662

allo- opened this issue Oct 21, 2022 · 3 comments
Labels
bug Something isn't working client network

Comments

@allo-
Copy link

allo- commented Oct 21, 2022

Describe the bug
xpra 5.0-r32148-1 cannot connect via ssh anymore.
Downgrading to version 5.0-r32078-1 fixes the issue for me, so the change must be a regeression between these two version.

xpra probably confuses the local and the remote username.

To Reproduce
Steps to reproduce the behavior:

  1. server command

    remoteuser@remotehost$ xpra start :10

  2. client command

    localuser@localhost$ xpra attach --ssh=/usr/bin/ssh ssh:remoteuser@server:10

  3. specific action to trigger the bug

Trying to connect with the client

System Information (please complete the following information):

  • Server OS: Debian stable
  • Client OS: Debian testing
  • Xpra Server Version 4.4-r0-1
  • Xpra Client Version 5.0-r32148-1

Additional context

2022-10-21 16:02:21,892 Error: SSH connection to the xpra server failed
2022-10-21 16:02:21,892  check your username, hostname, display number, firewall, etc
2022-10-21 16:02:21,892  for server: ssh://remoteuser@server:10
2022-10-21 16:02:21,893  the command line used was:
2022-10-21 16:02:21,893  /usr/bin/ssh -l localuser -p 10 -T server

The command line should contain -l remoteuser as parameter or remoteuser@server as connection string.

@allo- allo- added the bug Something isn't working label Oct 21, 2022
@totaam
Copy link
Collaborator

totaam commented Oct 21, 2022

Very likely 18720c1 or 998b9c5.
As a temporary workaround, you can use --ssh=ssh -l remoteuser.

totaam added a commit that referenced this issue Oct 21, 2022
also separate the ssh display attributes from the code that generates the full ssh command
@totaam
Copy link
Collaborator

totaam commented Oct 21, 2022

Fixed in 3e05f9a

FYI: the syntax ssh:remoteuser@server:10 is deprecated and may be removed in the future.
Please switch to a more standard URL syntax (#3599): ssh://user@host:port/

@totaam totaam closed this as completed Oct 21, 2022
@allo-
Copy link
Author

allo- commented Oct 21, 2022

That's, that was a fast fix. I'll update when there are new debian packages. If the error persists, I'll reopen, otherwise you can assume it works for me again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working client network
Projects
None yet
Development

No branches or pull requests

2 participants