Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

smaller hello packet #3812

Closed
totaam opened this issue Apr 2, 2023 · 1 comment
Closed

smaller hello packet #3812

totaam opened this issue Apr 2, 2023 · 1 comment
Labels
enhancement New feature or request

Comments

@totaam
Copy link
Collaborator

totaam commented Apr 2, 2023

There are too many things in it and most of them aren't really needed for the handshake.
There may be multiple hello packets sent when we're dealing with authentication and this is just a waste of space and bandwidth, it makes it harder to see what is really going on too.

TODO:

  • too much platform details
  • sound properties are mostly unused
  • icc data should be synchronized and sent separately

See also #3582

@totaam
Copy link
Collaborator Author

totaam commented Apr 2, 2023

With the changes above and logging with XPRA_LOG_RAW_PACKET_SIZE=1:

  • git master: sending hello : 8529 bytes
  • 4.4.x: sending hello : 157968 bytes

Quite the improvement!

There is a minor downside to this: when connecting to older servers, the newer clients won't be sending the icc data at all.. (since by the time we figure out that the server can't handle the new configure-display packet, it's too late and we have sent the hello without it)
And there's still some minor duplication: 2331672

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant