Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cython build error PyMemoryView_CheckExact #4111

Closed
totaam opened this issue Jan 30, 2024 · 3 comments
Closed

cython build error PyMemoryView_CheckExact #4111

totaam opened this issue Jan 30, 2024 · 3 comments
Labels
bug Something isn't working upstream

Comments

@totaam
Copy link
Collaborator

totaam commented Jan 30, 2024

Was wrongly attributed to clang in 11cca36.

C:/msys64/mingw64/bin/../lib/gcc/x86_64-w64-mingw32/13.2.0/../../../../x86_64-w64-mingw32/bin/ld.exe: build/temp.ming
w_x86_64-cpython-311/xpra/buffers/cyxor.o: in function `__pyx_pf_4xpra_7buffers_5cyxor_xor_str':
E:\xpra/xpra/buffers/cyxor.c:3263:(.text+0x2aef): undefined reference to `PyMemoryView_CheckExact'
collect2.exe: error: ld returned 1 exit status
error: command 'C:\\msys64\\mingw64\\bin/gcc.exe' failed with exit code 1

Caused by this function signature:

def xor_str(a, b) -> memoryview:

@totaam totaam added the bug Something isn't working label Jan 30, 2024
@totaam
Copy link
Collaborator Author

totaam commented Jan 30, 2024

Caused by #4110, was added in c623055.

No idea why this only fails on MS Windows!
This should be reported upstream.

@totaam totaam closed this as completed Jan 30, 2024
@totaam
Copy link
Collaborator Author

totaam commented Mar 7, 2024

Also seen on Linux with CC=clang, see also 11cca36 + 6907219

totaam added a commit that referenced this issue Apr 14, 2024
we can't add the 'memoryview' type hint because of #4111, so use 'ByteString' instead
@totaam totaam changed the title cython build error PyMemoryView_CheckExact on MS Windows cython build error PyMemoryView_CheckExact Jun 8, 2024
@totaam
Copy link
Collaborator Author

totaam commented Jun 8, 2024

Also seen on Linux Fedora 40.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working upstream
Projects
None yet
Development

No branches or pull requests

1 participant