Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nvenc is now padding video frames #4345

Closed
totaam opened this issue Sep 4, 2024 · 1 comment
Closed

nvenc is now padding video frames #4345

totaam opened this issue Sep 4, 2024 · 1 comment
Labels
bug Something isn't working encoding

Comments

@totaam
Copy link
Collaborator

totaam commented Sep 4, 2024

First reported in https://github.com/orgs/Xpra-org/discussions/4343#discussioncomment-10526895

Error with v5 and ffmpeg decoder:

2024-09-04 17:11:30,402 Error drawing on window 4
Traceback (most recent call last):
  File "/usr/lib64/python3.11/site-packages/xpra/client/mixins/window_manager.py", line 1592, in _do_draw
    window.draw_region(x, y, width, height, coding, data, rowstride,
  File "/usr/lib64/python3.11/site-packages/xpra/client/gui/client_window_base.py", line 838, in draw_region
    backing.draw_region(x, y, width, height, coding, img_data, rowstride, options, callbacks)
  File "/usr/lib64/python3.11/site-packages/xpra/client/gui/window_backing_base.py", line 923, in draw_region
    self.paint_with_video_decoder(VIDEO_DECODERS.get(coding),
  File "/usr/lib64/python3.11/site-packages/xpra/client/gui/window_backing_base.py", line 804, in paint_with_video_decoder
    img = vd.decompress_image(img_data, options)
          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "xpra/codecs/ffmpeg/decoder.pyx", line 1016, in xpra.codecs.ffmpeg.decoder.Decoder.decompress_image
    raise RuntimeError("%s context dimension %ix%i is smaller than the codec's expected size of %ix%i for frame %i" % (

Warning with openh264 decoder:

Warning: image bigger than expected
2024-09-04 17:13:17,607  1248x928 instead of 1240x900
@totaam totaam added bug Something isn't working encoding labels Sep 4, 2024
@totaam totaam changed the title nvenc is now padding video frames to 16 nvenc is now padding video frames Sep 4, 2024
totaam added a commit that referenced this issue Sep 4, 2024
totaam added a commit that referenced this issue Sep 4, 2024
@totaam
Copy link
Collaborator Author

totaam commented Sep 5, 2024

See also caf91e2

@totaam totaam closed this as completed Sep 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working encoding
Projects
None yet
Development

No branches or pull requests

1 participant