-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨Enable cut, copy and paste node #105
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the pull request!
We can do copy paste stuff now, nice. Definitely a core feature for any canvas editor. I've also noted that you've refactored the custom actions. Very nice!
I've noted the following behaviors:
Bugs:
-
Copy cut pasting 2 nodes linked together would copy 2 nodes unlinked and 1 empty node at coordinate (0,0)
-
The copy cut paste command works across different .xircuits using the context menu, but is buggy when transferring via ctrl + c -> ctrl +v. After closing the other xircuits the issue still persists, so might want to disable this feature in the meantime.
Would be nice to have in future pull requests:
- When pasting using context, paste at mouse location rather than at the original node position.
That's all for now. Ideally bug 1 should be fixed before merging since users will most probably try it out, and bug 2 can be easily commented out for now since cross xircuits bugs are troublesome.
Thanks for the review and comment. Finally solved the first bugs which took longer than expected. I agree with you regarding the second bugs as I commented out the command. I tried to solve it but haven't figure it out yet. Will add in the Wishlist. Also, fixed the name when creating xircuits file via launcher and context menu. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested and feels less buggy! Noted the future feature request log, so let's merge this.
Description
This will allow to cut, copy and paste any node via context menu or shortcuts.
For shortcut(Windows),
Pull Request Type
Type of Change
Tests
Tested on?