Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨Enable to do pip installation in different version #122

Merged
merged 7 commits into from
Mar 24, 2022

Conversation

AdrySky
Copy link
Contributor

@AdrySky AdrySky commented Mar 18, 2022

Description

This will allow different version of xircuits when pip installing. Currently have 2 version, default and full.

Pull Request Type

  • Xircuits Core (Jupyterlab Related changes)
  • Xircuits Canvas (Custom RD Related changes)
  • Xircuits Component Library
  • Testing Automation
  • Documentation
  • Others (Please Specify)

Type of Change

  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Tests

  1. Build the wheel
    1. pip install build
    2. python -m build
  2. Install the wheel(default) at different folder in new venv
    1. pip install ..dist/xircuits...whl
    2. Do pip list and check it's the same as requirement.txt
  3. Install the wheel(full)at different folder in new venv. Don't forget the [full] at the end.
    1. pip install ..dist/xircuits...whl[full]
    2. Do pip list and check it's the same as requirement-full.txt

Tested on?

  • Windows
  • Linux Ubuntu
  • Centos
  • Mac
  • Others (State here -> xxx )

Notes

Please do add/remove any library in the requirement/requirement-full.txt if required as I'm not sure which library is needed for the default ones and the full version. Thanks you

@AdrySky AdrySky added the enhancement New feature or request label Mar 18, 2022
@AdrySky AdrySky requested a review from MFA-X-AI March 18, 2022 04:15
@AdrySky AdrySky self-assigned this Mar 18, 2022
@MFA-X-AI
Copy link
Member

Awesome. This will really help if we want to do speed devs and installing only core features. Tested on windows and working.

@MFA-X-AI MFA-X-AI merged commit b975a49 into master Mar 24, 2022
@MFA-X-AI MFA-X-AI deleted the adry/install-different-version branch March 24, 2022 04:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants