Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 Fix Xircuits start in Linux #125

Merged
merged 2 commits into from
Mar 25, 2022
Merged

🐛 Fix Xircuits start in Linux #125

merged 2 commits into from
Mar 25, 2022

Conversation

MFA-X-AI
Copy link
Member

@MFA-X-AI MFA-X-AI commented Mar 24, 2022 •
edited
Loading

Description

Previous launch via xircuits in linux was hard coded. This PR makes it slightly smarter.

References

#85

Pull Request Type

  • Xircuits Core (Jupyterlab Related changes)
  • Xircuits Canvas (Custom RD Related changes)
  • Xircuits Component Library
  • Testing Automation
  • Documentation
  • Others (Please Specify)

Type of Change

  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Tests

1. Test Xircuits Start in Linux

1. Create venv in Linux with any name you want
2. install xircuits
3. launch xircuits with `xircuits`

Tested on?

  • Windows
  • Linux Ubuntu
  • Centos
  • Mac
  • Others (State here -> xxx )

Notes

Add if any.

@MFA-X-AI MFA-X-AI requested a review from AdrySky March 24, 2022 08:15
AdrySky
AdrySky approved these changes Mar 25, 2022
View reviewed changes
Copy link
Contributor

@AdrySky AdrySky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested. Working great. Thanks.

@AdrySky AdrySky merged commit 0333579 into master Mar 25, 2022
@AdrySky AdrySky deleted the fahreza/start-fix branch March 25, 2022 03:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AdrySky AdrySky AdrySky approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MFA-X-AI @AdrySky