Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨Add context menu option to open node's script #127

Merged
merged 1 commit into from
Mar 28, 2022
Merged

✨Add context menu option to open node's script #127

merged 1 commit into from
Mar 28, 2022

Conversation

AdrySky
Copy link
Contributor

@AdrySky AdrySky commented Mar 25, 2022 •
edited
Loading

Description

This will enable to open the python script of node in canvas.

Pull Request Type

  • Xircuits Core (Jupyterlab Related changes)
  • Xircuits Canvas (Custom RD Related changes)
  • Xircuits Component Library
  • Testing Automation
  • Documentation
  • Others (Please Specify)

Type of Change

  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Tests

  1. Drop any node via sidebar or component panel
  2. Open context menu on the node (ctrl+left-click)
  3. Select Open Script
  4. It'll open its script

Tested on?

  • Windows
  • Linux Ubuntu
  • Centos
  • Mac
  • Others (State here -> xxx )

Notes

It's only works for any latest dropped node. Any old nodes that's already on canvas will not work as it doesn't have file_path data.

@AdrySky AdrySky added the enhancement New feature or request label Mar 25, 2022
@AdrySky AdrySky requested a review from MFA-X-AI March 25, 2022 03:08
@AdrySky AdrySky self-assigned this Mar 25, 2022
MFA-X-AI
MFA-X-AI approved these changes Mar 28, 2022
View reviewed changes
Copy link
Member

@MFA-X-AI MFA-X-AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the pull request!
Tested on windows and linux, the feature works perfectly. By adding the python path to the components, it'll also help with the xircuits2python converter.
Awesome work!

@MFA-X-AI MFA-X-AI merged commit 0c71009 into master Mar 28, 2022
@MFA-X-AI MFA-X-AI deleted the adry/option-open-script branch March 28, 2022 01:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MFA-X-AI MFA-X-AI MFA-X-AI approved these changes

Assignees

@AdrySky AdrySky

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AdrySky @MFA-X-AI