-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨Allow multiple link for port with string, list and dict type #137
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR!
I'm getting some issues in the codegen side of things, literal nodes are sometimes returning undefined values. Here's the gist for KerasTrainImageClassifier.
https://gist.github.com/MFA-X-AI/9be15e0abafb7003371905adb3c7ed28
To reproduce, simply run the codeegn.
I'm investigating further what causes it.
Sorry. I forgot to put value for Also, I allow multiple links for same link and port |
Thanks for the fixes.
issue1- Append list,dict,str when the input node is [list,dict or str] type |
Thanks @mansouralawi for the review. Both issue fixed on my side. Appreciate if you could review again. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fixes.
- Literal nodes are sometimes returning undefined values:
issue is fixed
- Append list,dict,str when input node is [any] type
working fine
- Append list,dict,str when the input node is [list,dict or str] type
working fine
- Appending literals although they belong to different input nodes. 'issue is fixed'
Issue
1- Appending 2 trained models of type [any] to input node type [any] produce the error below. (The target is to append the two models to a list)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As discussed, the any
implementation requires additional features to be added, but for string
list
and dict
it's perfect. Tested and working.
One interesting to note was the order of the append - it follows the order of when the link was created. In the future it would be cool to indicate the order, perhaps by link label.
Description
This enable connecting multiple link into port with
string
,list
anddict
type which in the codegen side, append the extra values.Pull Request Type
Type of Change
Tests
string
type.string
.list
anddict
.Tested on?
Notes
The original PR focused on enabling multiports for the
any
type, but as discussed, the intended use case implementation via multiports could not be implemented in this PR.