Skip to content

🐛Fix component panel auto-scroll back to top. #143

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 4, 2022
Merged

🐛Fix component panel auto-scroll back to top. #143

merged 1 commit into from
Apr 4, 2022

Conversation

AdrySky
Copy link
Contributor

@AdrySky AdrySky commented Apr 4, 2022 •
edited
Loading

Description

This fix scrolling through component panel and selecting a component but it scroll to top instead of adding the node.

Bug(Gif):
Animation

Pull Request Type

  • Xircuits Core (Jupyterlab Related changes)
  • Xircuits Canvas (Custom RD Related changes)
  • Xircuits Component Library
  • Testing Automation
  • Documentation
  • Others (Please Specify)

Type of Change

  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Tests

  1. Open component panel(Right-click)
  2. Open any category
  3. Scroll through bottom and choose a component
  4. It's expected to add the node instead of scroll back to top(Shown in Gif)

Tested on?

  • Windows
  • Linux Ubuntu
  • Centos
  • Mac
  • Others (State here -> xxx )

@AdrySky AdrySky added the bug Something isn't working label Apr 4, 2022
@AdrySky AdrySky requested a review from MFA-X-AI April 4, 2022 06:53
@AdrySky AdrySky self-assigned this Apr 4, 2022
@mansouralawi
Copy link
Member

Great work, the bug seems to be addressed well and fixed.

auto-scroll

@mansouralawi mansouralawi merged commit 0299479 into master Apr 4, 2022
@mansouralawi mansouralawi deleted the adry/fix-panel-autoscroll branch April 4, 2022 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MFA-X-AI MFA-X-AI Awaiting requested review from MFA-X-AI

Assignees

@AdrySky AdrySky

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AdrySky @mansouralawi