-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Enable Arg Parsing in Xircuits Entry Point #149
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the PR.
Passed tests
- Download components
xircuits --branch fahreza/component-submodules
No pycaret or modelstash components but it launched Xircuits (expected)
- Download examples
xircuits-examples --branch fahreza/component-submodules
No AutoML examplesxircuits-examples --branch invalid_branch_name
returned the error message
Failed test
- Download components
xircuits --branch invalid_branch_name
No error message and launched Xircuits
Suggested improvement
- To introduce
xircuits-components
similarly toxircuits-examples
to download components.
Oh, for this one you'd need to delete the xai_component folder first since it performs a folder check on start. That does remind me, maybe we can add an entry point just to download the xai_components. |
When deleting the xai_component folder and running An additional entry point specific for xai_components download is a good idea. |
Cool. I'll add it to the next "call submodules from entry" PR. :D |
Description
This PR enables passing arguments from the xircuits console entry point. I've applied it so that we can pull
xai_components
,examples
anddatasets
from branches.The two things you can do now is:
xircuits --branch branchName
to pullxai-components
xircuits-examples --branch branchName
to pullexamples
anddatasets
from your specified branch name. I've also added error handling for file pulling and invalid branches.
References
#131 #132
Pull Request Type
Type of Change
Tests
The branch
fahreza/component-submodules
can be used to test differences between master and branch.1. Test Entry Point
xircuits --branch fahreza/component-submodules
, accept to downloadxai_components
when prompted2. Test Example Downloading
xircuits-examples --branch fahreza/component-submodules
3. Test Exception Handling
xircuits --branch
orxircuits-examples --branch
with an invalid branch nameexamples from XpressAi/Xircuits branch invalidBranch does not exist!
Tested on?
Notes
Datasets
directory to match the rest of the repository.files
instead ofdir
in pygithub and will return a invalid file message. Nonetheless, the rest of the components will be downloaded.