-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
⚡️Compatibility with python 3.8 and above versions #161
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR!
Having more python version reports are definitely important. Glad to know 3.10+ is also compatible with the current build.
During testing, I think there's still a print statement.
Name(id='any', ctx=Load())
Name(id='any', ctx=Load())
I've also noticed that we may need to take the
Uncaught (in promise) TypeError: Cannot read properties of undefined (reading 'getOptions')
bug in a higher priority. It triggered when I was creating the wheel for 3.8, then trying the component drop feature.
It is not related to this PR I believe, as it also triggers when building without a package-lock.json. As per @AdrySky's comment, it may be that one of our jupyterlab packages are no longer compatible with RD. Will need further investigation before merging.
Thank you for your review. I have removed the print statement. Noted on the build issue, I will be waiting for an update on that to re-test this PR build again. |
Bumps [eventsource](https://github.com/EventSource/eventsource) from 1.1.0 to 1.1.1. - [Release notes](https://github.com/EventSource/eventsource/releases) - [Changelog](https://github.com/EventSource/eventsource/blob/master/HISTORY.md) - [Commits](EventSource/eventsource@v1.1.0...v1.1.1) --- updated-dependencies: - dependency-name: eventsource dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com>
🐛Fix adding node via link
…urce-1.1.1 Bump eventsource from 1.1.0 to 1.1.1
….com/XpressAI/xircuits into mansour/python_version_compatibility
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
with bugfix #162, I can verify that things work out nicely.
Built the wheel using 3.8, installed the wheel.
Components are correctly rendered and I can run simple components in the template library. Great work!
Description
We have identified that those two methods (str.removeprefix and ast.unparse) stop us from supporting python versions < 3.9. the current changes add support for python versions > 3.8.
AST parsing differences between different Python versions:
What is preventing Xircuits from running on Python 3.7 is the missing of
end_lineno
andend_col_offset
from the AST parse.References
this PR is based on an older PR #87
Pull Request Type
Type of Change
Tests
Manual test for same Xircuits behaviour and features as before:
Xircuits
Tested on?
Notes
Add if any.