Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛Update spawn point when component panel is open #179

Merged
merged 1 commit into from
Jul 26, 2022
Merged

🐛Update spawn point when component panel is open #179

merged 1 commit into from
Jul 26, 2022

Conversation

AdrySky
Copy link
Contributor

@AdrySky AdrySky commented Jul 26, 2022 •
edited
Loading

Description

This will fix menu spawn position regardless which left sidebar is open.

Pull Request Type

  • Xircuits Core (Jupyterlab Related changes)
  • Xircuits Canvas (Custom RD Related changes)
  • Xircuits Component Library
  • Testing Automation
  • Documentation
  • Others (Please Specify)

Type of Change

  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Tests

  1. Open context menu regardless which left sidebar is currently open.
  2. It should spawn in the correct position

Tested on?

  • Windows
  • Linux Ubuntu
  • Centos
  • Mac
  • Others (State here -> xxx )

@AdrySky AdrySky added the bug Something isn't working label Jul 26, 2022
@AdrySky AdrySky requested a review from MFA-X-AI July 26, 2022 01:44
@AdrySky AdrySky self-assigned this Jul 26, 2022
MFA-X-AI
MFA-X-AI approved these changes Jul 26, 2022
View reviewed changes
Copy link
Member

@MFA-X-AI MFA-X-AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Solid. Opening tabs and component panel also works nicely.
fixed spawn
Great work, merging~

@MFA-X-AI MFA-X-AI merged commit 76320f4 into master Jul 26, 2022
@MFA-X-AI MFA-X-AI deleted the adry/get-sidebar-element branch July 26, 2022 05:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MFA-X-AI MFA-X-AI MFA-X-AI approved these changes

Assignees

@AdrySky AdrySky

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AdrySky @MFA-X-AI