Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Fix Extra Ports for Start and Finish Nodes #192

Merged
merged 1 commit into from
Sep 12, 2022

Conversation

MFA-X-AI
Copy link
Member

@MFA-X-AI MFA-X-AI commented Sep 5, 2022

Description

Earlier Xircuits workflows has an extra port for the Start and Finish nodes. This PR removes them. The updated workflows are:

  • KerasModelPredict
  • KerasTrainImageClassifier
  • SparkLinePlot
  • SparkLogisticRegression
  • SparkPackageVenv
  • SparkSQLPlotBar
  • UtilsZipDirectory

Pull Request Type

  • Xircuits Core (Jupyterlab Related changes)
  • Xircuits Canvas (Custom RD Related changes)
  • Xircuits Component Library
  • Testing Automation
  • Documentation
  • Others (Please Specify)

Type of Change

  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Tests

1. Integrity Check

  1. Clone the repo, checkout to fahreza/fix-original-ports, install xircuits
  2. Verify that the above examples does not have extra ports.
  3. Verify that you are able to compile and run it. You don't have to run all of them.

Tested on?

  • Windows
  • Linux Ubuntu
  • Centos
  • Mac
  • Others (State here -> xxx )

Notes

Add if any.

@MFA-X-AI MFA-X-AI requested a review from AdrySky September 12, 2022 09:00
Copy link
Contributor

@AdrySky AdrySky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked that all Start and Finish node in the mentioned xircuits only has 1 port. Thanks.

@AdrySky AdrySky merged commit f37682e into master Sep 12, 2022
@AdrySky AdrySky deleted the fahreza/fix-original-ports branch September 12, 2022 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants