Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update General Component #207

Merged
merged 6 commits into from
Feb 17, 2023
Merged

Update General Component #207

merged 6 commits into from
Feb 17, 2023

Conversation

mansouralawi
Copy link
Member

Description

This PR is to update the general components' layout and naming

Pull Request Type

  • Xircuits Core (Jupyterlab Related changes)
  • Xircuits Canvas (Custom RD Related changes)
  • Xircuits Component Library
  • Xircuits Project Template
  • Testing Automation
  • Documentation
  • Others (Please Specify)

Type of Change

  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • This change requires templates and examples updated

Tests

1. Load general components (Arguments, Literal)
2. Check components' color match with schema 
3. Check hyperparameter naming is changed to Argument 

Tested on?

  • Windows
  • Linux Ubuntu
  • Centos
  • Mac
  • Others (State here -> xxx )

Notes

color schema:

  • Str: Pink
  • Int: Blue
  • Float: Green
  • Bool: Red
  • List: Yellow
  • Tuple: Purple
  • Dict: Orange

image

Copy link
Member

@MFA-X-AI MFA-X-AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!
Unfortunately this breaks on compile if you use any argument component.

error

The second one is what is expected if you use the hyperparameter / argument component. There might be more strings to change in the bodywidget.

@mansouralawi
Copy link
Member Author

Thanks for the Review. yes, apparently some naming change is required in the bodywidget as well. but I think it is working fine now.
Animation

Copy link
Member

@MFA-X-AI MFA-X-AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update! Looks solid now.
updated general component
In the process I've noted that some of our examples need updating and / or version locking. A good time before the next release. Thanks for the PR, merging.

@MFA-X-AI MFA-X-AI merged commit 2034255 into master Feb 17, 2023
@MFA-X-AI MFA-X-AI deleted the mansour/update-general-component branch February 17, 2023 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants