Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📖 / 🐛 XAI Spark Examples Update #218

Merged
merged 1 commit into from
Mar 7, 2023

Conversation

MFA-X-AI
Copy link
Member

@MFA-X-AI MFA-X-AI commented Mar 2, 2023

Description

A validation patch before 1.7 release. I've tested the examples with the newer Spark 3.3.2 that was recently released (17 Feb 23). Made sure that all examples run smoothly and fixed some bugs.

Pull Request Type

  • Xircuits Core (Jupyterlab Related changes)
  • Xircuits Canvas (Custom RD Related changes)
  • Xircuits Component Library
  • Xircuits Project Template
  • Testing Automation
  • Documentation
  • Others (Please Specify)

Type of Change

  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Tests

Run all Spark related examples in the examples directory. They should run from start to finish.

Tested on?

  • Windows
  • Linux Ubuntu
  • Centos
  • Mac
  • Others (State here -> xxx )

Notes

The Spark Xircuits canvases here are quite old and didn't have the newer 3 d.p. coordinate saving format. You'll see a lot of lines changed for those workflows because of this.

Copy link
Member

@mansouralawi mansouralawi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR

@mansouralawi mansouralawi merged commit ae74f83 into master Mar 7, 2023
@mansouralawi mansouralawi deleted the fahreza/1.7-update-spark branch March 7, 2023 05:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants