Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Fix Component Panel Freeze on Spawn #294

Merged
merged 1 commit into from
Feb 16, 2024

Conversation

MFA-X-AI
Copy link
Member

Description

Due to the cache implemented in #293, things work much faster to the point where we discovered a bug where spawning the interface would loop freeze jupyterlab.

References

#293

Pull Request Type

  • Xircuits Core (Jupyterlab Related changes)
  • Xircuits Canvas (Custom RD Related changes)
  • Xircuits Component Library
  • Xircuits Project Template
  • Testing Automation
  • Documentation
  • Others (Please Specify)

Type of Change

  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Tests

Open a canvas. Try the chain component interface. It should properly spawn and not freeze the interface.

Tested on?

  • Windows
  • Linux Ubuntu
  • Centos
  • Mac
  • Others (State here -> xxx )

Copy link

Binder 👈 Launch a binder notebook on branch XpressAI/xircuits/fahreza/fix-fetch-component-panel-spawn

@MFA-X-AI MFA-X-AI merged commit a4257f0 into master Feb 16, 2024
9 checks passed
@MFA-X-AI MFA-X-AI deleted the fahreza/fix-fetch-component-panel-spawn branch February 16, 2024 05:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants