Click Link to Select, CTRL+Click to add a Point

[treo]

Description

The old click to add point functionality grew quite annoying very quickly. In particular if we want to modify the graph to add some component, using shift+click to select a link ended up also selecting the node, because that particular behavior is meant for selecting multiple things.

By moving the add-point-to-link functionality to ctrl+click, we free up the regular click to be just a select, exactly how one expects it to be.

This also enables figma-like pinch-to-zoom and two-finger panning.

Pull Request Type

• Xircuits Core (Jupyterlab Related changes)
• Xircuits Canvas (Custom RD Related changes)
• Xircuits Component Library
• Xircuits Project Template
• Testing Automation
• Documentation
• Others (Please Specify)

Type of Change

• New feature (non-breaking change which adds functionality)
• Bug fix (non-breaking change which fixes an issue)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• This change requires a documentation update

Tests

1. Manual Test

1. Create a link between two nodes (Start to finish is fine)
2. Click the link to select it
3. Before: Link node gets created; After: Link is selected
4. CTRL+Click the link
5. Before: Add component menu opens; After: Link node gets created

Tested on?

• Windows
• Linux Ubuntu
• Centos
• Mac
• Others (State here -> xxx )

[github-actions]

👈 Launch a binder notebook on branch XpressAI/xircuits/paul/click-link-to-select