Only handle events for the correct widget #335
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We've run into the issue that the xircuits widget would handle event's that aren't meant for it (e.g. copy & paste in a text editor would result in the widget pasting things that may have been copied previously).
At the core of the issue lies the event handler being attached to document, but as that is being done by the underlying diagram engine, we can't change that as easily.
As a workaround, we're passing a way to acquire the widget id down to the event handler, so it can check if it is supposed to handle the event.
We must pass on a function instead of giving it the id directly, because the id isn't yet available during construction.
Pull Request Type
Type of Change
Tests
1. Manual Test
Tested on?