Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 / ✨ Component Panel: Fix Clipping, Add Escape Key, Improve Interactions #369

Merged
merged 5 commits into from
Jan 13, 2025

Conversation

MFA-X-AI
Copy link
Member

@MFA-X-AI MFA-X-AI commented Jan 13, 2025

Description

This PR implements several UI/UX improvements for the Xircuits Canvas interface:

  1. Fixed component panel chain link interface to allow deleting search text by preventing propagation
  2. Prevented component panel from spawning from Literals nodes
  3. Added ability to dismiss component panel and context menu via Escape key
  4. Fixed component panel and context menu min-height inheritance issue that was causing click-blocking
  5. Implemented viewport clamping to prevent component panel from being clipped off-screen

It also adds a shadow to component panel and context menu.

Pull Request Type

  • Xircuits Core (Jupyterlab Related changes)
  • Xircuits Canvas (Custom RD Related changes)
  • Xircuits Component Library
  • Xircuits Project Template
  • Testing Automation
  • Documentation
  • Others

Type of Change

  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change
  • This change requires a documentation update

Tests

1. Chain Link Search Deletion Test

1. Create a chain link and open search interface
2. Type and attempt to delete text
3. Verify text deletion works without canvas interference

2. Literal Node Component Panel Test

1. Create a Literal node
2. Drag a link from its output port
3. Verify no component panel appears
4. Verify normal nodes still spawn panel correctly

3. Component Panel Escape Key Test

1. Open component panel via right-click or link drag
2. Press Escape key
3. Verify panel closes immediately

4. Panel Height

1. Open component panel
2. Click elements beneath panel area
3. Confirm no click-blocking issues

5. Viewport Clipping Test

1. Spawn panel near screen edges (right, bottom, corners)
2. Verify panel stays within viewport

Tested on?

  • Windows
  • Linux Ubuntu
  • Centos
  • Mac
  • Others

Copy link

Binder 👈 Launch a binder notebook on branch XpressAI/xircuits/fahreza/fix-comp-panel-propagation

@MFA-X-AI MFA-X-AI requested a review from treo January 13, 2025 11:50
@MFA-X-AI MFA-X-AI merged commit d1bd577 into master Jan 13, 2025
9 checks passed
@MFA-X-AI MFA-X-AI deleted the fahreza/fix-comp-panel-propagation branch January 13, 2025 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants