-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛Fix path to open components script #94
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the pull request!
I've tested this on Windows, the bug fix works perfectly when building from source, but fails when using the wheel to install. I've tried both the wheel from the new action and from building from the repo. As we're planning to publish this on pypi soon, having things work on the wheel should be a priority as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the update! Tested and working in Windows, in Linux WSL looks like the handler isn't working well. Here's the errorlog that I got:
[W 2022-01-31 13:46:56.483 ServerApp] No such file or directory: xai_modelstash/modelstash_core.py
[W 2022-01-31 13:46:56.484 ServerApp] 404 GET /api/contents/xai_modelstash/modelstash_core.py?content=0&1643611617332 (127.0.0.1) 1.83ms referer=http://localhost:8888/lab/tree/untitled.xircuits
From more inspection, the chrome debugger threw out this log.
It's missing the starting "/". |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Works perfectly.
Tested on Windows and Linux, we can open the python file via tray widget. Good work!
Description
This fix double clicking and ctrl-click a component library to open its python script.
Pull Request Type
Type of Change
Tests
Tested on?