Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛Fix path to open components script #94

Merged
merged 5 commits into from
Feb 11, 2022

Conversation

AdrySky
Copy link
Contributor

@AdrySky AdrySky commented Jan 28, 2022

Description

This fix double clicking and ctrl-click a component library to open its python script.

Pull Request Type

  • Xircuits Core (Jupyterlab Related changes)
  • Xircuits Canvas (Custom RD Related changes)
  • Xircuits Component Library
  • Documentation
  • Others (Please Specify)

Type of Change

  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Tests

  1. Ctrl+click any component in component_library to open its script.
  2. Also, try double clicking.

Tested on?

  • Windows
  • Linux Ubuntu
  • Centos
  • Mac
  • Others (State here -> xxx )

@AdrySky AdrySky added the bug Something isn't working label Jan 28, 2022
@AdrySky AdrySky requested a review from MFA-X-AI January 28, 2022 03:56
@AdrySky AdrySky self-assigned this Jan 28, 2022
Copy link
Member

@MFA-X-AI MFA-X-AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the pull request!
I've tested this on Windows, the bug fix works perfectly when building from source, but fails when using the wheel to install. I've tried both the wheel from the new action and from building from the repo. As we're planning to publish this on pypi soon, having things work on the wheel should be a priority as well.

@AdrySky AdrySky requested a review from MFA-X-AI January 31, 2022 03:35
Copy link
Member

@MFA-X-AI MFA-X-AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update! Tested and working in Windows, in Linux WSL looks like the handler isn't working well. Here's the errorlog that I got:

[W 2022-01-31 13:46:56.483 ServerApp] No such file or directory: xai_modelstash/modelstash_core.py
[W 2022-01-31 13:46:56.484 ServerApp] 404 GET /api/contents/xai_modelstash/modelstash_core.py?content=0&1643611617332 (127.0.0.1) 1.83ms referer=http://localhost:8888/lab/tree/untitled.xircuits

@MFA-X-AI
Copy link
Member

From more inspection, the chrome debugger threw out this log.

Uncaught (in promise) Error: No such file or directory: home/fahreza-ubuntu/Github/xircuits-wheel/xai_components/xai_modelstash/modelstash_core.py

It's missing the starting "/".

@AdrySky AdrySky requested a review from MFA-X-AI February 11, 2022 08:02
Copy link
Member

@MFA-X-AI MFA-X-AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Works perfectly.
Tested on Windows and Linux, we can open the python file via tray widget. Good work!

@MFA-X-AI MFA-X-AI merged commit 5587450 into master Feb 11, 2022
@MFA-X-AI MFA-X-AI deleted the adry/fix-opening-component-script branch February 11, 2022 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants