Integrate Oauth helper into SC #562
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rosinghal
reviewed
Jul 18, 2024
|
Do we know what the impact will be for people using the OAuth Helper plugin if they get this feature in the core plugin itself? |
We have added condition that if the Oauth Helper is activated, then files are not run in core plugin until we deactivate Oauth helper add on. We also add notice in admin to do this. |
rosinghal
approved these changes
Aug 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: Integrate Oauth helper into SC Plugin. If the GCal Pro or Appointment is activated, then Oauth settings will display in the admin
Clickup: https://app.clickup.com/t/86cvy8rkf