refactor: Extract some hardcoded strings

Xtr126 · Aug 1, 2024 · b2d0c92 · b2d0c92
1 parent 0571d41
commit b2d0c92
Show file tree

Hide file tree

Showing 3 changed files with 25 additions and 9 deletions.
diff --git a/app/src/main/res/menu/keymap_editor_menu.xml b/app/src/main/res/menu/keymap_editor_menu.xml
@@ -3,30 +3,30 @@
  <item
  android:id="@+id/dpad"
  android:icon="@drawable/dpad"
- android:title="D-Pad" />
+ android:title="@string/d_pad" />
  <item
  android:id="@+id/crosshair"
  android:icon="@drawable/crosshair"
- android:title="CrossHair" />
+ android:title="@string/crosshair" />
  <item
  android:id="@+id/mouse_left"
  android:icon="@drawable/ic_baseline_mouse_36"
- android:title="Left Click" />
+ android:title="@string/left_click" />
  <item
  android:id="@+id/mouse_right"
  android:icon="@drawable/ic_baseline_mouse_36"
- android:title="Right Click" />
+ android:title="@string/right_click" />
  <item
  android:id="@+id/swipe_key"
  android:icon="@drawable/ic_baseline_touch_app_24"
- android:title="Swipe Key" />
+ android:title="@string/swipe_key" />
  <item
  android:id="@+id/add"
  android:icon="@drawable/newkey"
- android:title="Add Key" />
+ android:title="@string/add_key" />
 
  <item
  android:id="@+id/save"
  android:icon="@drawable/ic_baseline_done_36"
- android:title="Save" />
+ android:title="@string/save" />
 </menu>
diff --git a/app/src/main/res/values-zh-rCN/strings.xml b/app/src/main/res/values-zh-rCN/strings.xml
@@ -48,7 +48,7 @@
  <string name="swipe_delay_ms">滑动延迟 %d 毫秒</string>
  <string name="profile_name">配置名称</string>
  <string name="root_not_found_title">未获取 root 权限</string>
- <string name="root_not_found_message">键映射器需要获取root权限才能运行。\n请从 KernelSU 管理器应用向 XtMapper 授予权限：</string>
+ <string name="root_not_found_message">键映射器需要获取root权限才能运行。\n请从 KernelSU 管理器应用向 XtMapper 授予权限</string>
  <string name="root_no_privileges_title">服务无法以 root 权限启动</string>
  <string name="root_no_privileges_message">
  无法获得权限。您想退出程序吗？\n
@@ -61,4 +61,12 @@
  <string name="pointer">指针模式</string>
  <string name="open_editor_as_overlay">以叠加方式打开编辑器</string>
 
+ <!-- Keymap editor -->
+ <string name="d_pad">D-Pad</string>
+ <string name="crosshair">CrossHair</string>
+ <string name="left_click">Left Click</string>
+ <string name="swipe_key">Swipe Key</string>
+ <string name="add_key">Add Key</string>
+ <string name="save">Save</string>
+
 </resources>
diff --git a/app/src/main/res/values/strings.xml b/app/src/main/res/values/strings.xml
@@ -49,7 +49,7 @@
  <string name="swipe_delay_ms">Swipe delay %d milliseconds</string>
  <string name="profile_name">Profile Name</string>
  <string name="root_not_found_title">Root access not found</string>
- <string name="root_not_found_message">Root access is required for the keymapper to function. \n Please grant superuser to XtMapper from KernelSU manager app:</string>
+ <string name="root_not_found_message">Root access is required for the keymapper to function. \n Please grant superuser to XtMapper from KernelSU manager app</string>
  <string name="root_no_privileges_title">Service failed to start as root</string>
  <string name="root_no_privileges_message">
  Unable to obtain privileges. Do you want to exit the application?\n
@@ -62,4 +62,12 @@
  <string name="pointer">Pointer Mode</string>
  <string name="open_editor_as_overlay">Open editor as overlay</string>
 
+ <!-- Keymap editor -->
+ <string name="d_pad">D-Pad</string>
+ <string name="crosshair">CrossHair</string>
+ <string name="left_click">Left Click</string>
+ <string name="swipe_key">Swipe Key</string>
+ <string name="add_key">Add Key</string>
+ <string name="save">Save</string>
+
 </resources>