Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Chinese language #101

Merged
merged 7 commits into from
Aug 1, 2024
Merged

Add Chinese language #101

merged 7 commits into from
Aug 1, 2024

Conversation

guobao2333
Copy link
Contributor

Although I have added Chinese to your application. some parts are hard coded.

Besides, I found some problems with the layout of your application, but it has nothing to do with the language. You may need to fix this problem.

@Xtr126
Copy link
Owner

Xtr126 commented Aug 1, 2024

Thanks for your contribution.
I extracted some of the hard coded strings from the editor interface. They can be translated now.

@guobao2333
Copy link
Contributor Author

guobao2333 commented Aug 1, 2024

@Xtr126 You can now merge the code. Wait, there are several hard codes.

@guobao2333
Copy link
Contributor Author

I modified the previous translation by decompiling the built installation package, and now I need to prepare the construction from scratch.

It's because I was lazy, and I still don't remember where there is hard coding, so please wait for me for a moment.

@guobao2333
Copy link
Contributor Author

@Xtr126 There are three hard codes as shown in the figure below.

Screenshot_2024-08-01-14-18-32-42
Screenshot_2024-08-01-14-18-41-12

@Xtr126
Copy link
Owner

Xtr126 commented Aug 1, 2024

They are exposed dropdown menus: https://github.com/material-components/material-components-android/blob/master/docs/components/Menu.md#exposed-dropdown-menu-example
I'm trying to find a way to translate them using string arrays.

@Xtr126
Copy link
Owner

Xtr126 commented Aug 1, 2024

@guobao2333 Now they can be translated:

@guobao2333
Copy link
Contributor Author

Your project may not be well known, But I would still recommend using the Crowdin website to manage the localization translation work of the project.

Although there are many people in China, few people participate in the translation work. I also found a very interesting thing. As long as the translation channels are opened for most applications, almost all Chinese will be translated😂.

Well, I won't flatter myself. You can really merge projects now.

@Xtr126
Copy link
Owner

Xtr126 commented Aug 1, 2024

Your project may not be well known, But I would still recommend using the Crowdin website to manage the localization translation work of the project.

Although there are many people in China, few people participate in the translation work. I also found a very interesting thing. As long as the translation channels are opened for most applications, almost all Chinese will be translated😂.

Well, I won't flatter myself. You can really merge projects now.

I agree with you, translations should be made easier. I'll look into setting up crowdin, thanks for the suggestion. Initially I was focusing on the functionality as it took a long while to get it to a usable state.

@Xtr126 Xtr126 merged commit 6f9c4be into Xtr126:dev Aug 1, 2024
@Xtr126
Copy link
Owner

Xtr126 commented Aug 1, 2024

Anyone who wants to test the changes can do so by downloading the artifact from https://github.com/Xtr126/XtMapper/actions/runs/10199678072

Xtr126 added a commit that referenced this pull request Aug 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants