Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add FreeBSD/OpenBSD support. #12

Merged
merged 1 commit into from
May 17, 2020
Merged

Add FreeBSD/OpenBSD support. #12

merged 1 commit into from
May 17, 2020

Conversation

lcook
Copy link
Contributor

@lcook lcook commented May 16, 2020

Since there's no definition for detectors for either [Free/Open]BSD it'll fail to build:

(lcook@darkstar:go-locale) (git)[master:2bb2ed4]
% uname -a
FreeBSD darkstar 12.1-RELEASE-p3 FreeBSD 12.1-RELEASE-p3 GENERIC  amd64
(lcook@darkstar:go-locale) (git)[master:2bb2ed4]
% go build
# github.com/Xuanwo/go-locale
./locale.go:40:21: undefined: detectors

Adding both locale_freebsd and locale_openbsd provides that definition and subsequently fixes this.

@codecov
Copy link

codecov bot commented May 16, 2020

Codecov Report

Merging #12 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master       #12   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            2         2           
  Lines           31        31           
=========================================
  Hits            31        31           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2bb2ed4...1b4dc2b. Read the comment docs.

@Xuanwo
Copy link
Owner

Xuanwo commented May 17, 2020

LGTM!

@Xuanwo Xuanwo merged commit 786e297 into Xuanwo:master May 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants