fix: Use logging-only variables in release profile
#30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Due to the logging format used, the existing `format_args` macro matches the logging macro args. It can be used to consume the variables used for logging, yet the output isn't used anywhere. Because this only happens in the `release` profile, `rustc` will remove the code completely.
pavel@machine:~/Work/serde-env$ cargo build --release
Compiling serde-env v0.1.1 (/home/pavel/Work/serde-env)
Finished release [optimized] target(s) in 0.47s |
|
Great! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to the logging format used, the existing
format_argsmacro matches the logging macro args. It can be used to consume the variables used for logging, yet the output isn't used anywhere. Because this only happens in thereleaseprofile,rustcwill remove the code completely.