refactor!: remove logging #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Based on #34 |
Pscheidl
force-pushed
the
log-test-scope
branch
2 times, most recently
from
3a762f2 to
58044da
Compare
|
@Xuanwo looks like two jobs timed out before a suitable runner was a CV available. Would you mind restarting them ? TY. |
|
Hi, I feel like we can remove those log entirely. They exists while developing, and I never hit a case when I need to read them to debug since 0.1.1 has been released. Maybe this is the time. |
|
That's the best solution really. I'll do that. |
Pscheidl
changed the title
Removed logging completely. This eliminates the risk of logging being secretely enabled by other dependencies via the `log` feature, revealing potential secrets.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The log crate is now a dev dependency. Logging
only happens when running in the test scope -
cfg(test). This eliminates the risk of logging being secretely enabled by other dependencies, revealing potential secrets.